Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mute wallet ui error message on rejected request #460

Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Dec 11, 2024

Mute the error message if user denied the operation of :

  • starkNet_executeTxn
  • starkNet_addErc20Token
  • starkNet_upgradeAccContract
  • starkNet_createAccountLegacy
  • starkNet_displayPrivateKey

BEGIN_COMMIT_OVERRIDE
fix: Mute Wallet UI error message when user deny a request (#460)
END_COMMIT_OVERRIDE

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 11, 2024 08:32
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team December 11, 2024 08:32
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 8027bc2 Dec 11, 2024
15 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/mute-error-message-when-snap-request-rejected branch December 11, 2024 11:02
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants